This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Repository navigation
add to actually delete all config files when the service is stopped - #96
Merged
Merged
Conversation
mmou
commented
Apr 28, 2020
| @@ -42,7 +42,7 @@ func main() { | |||
| cli.BoolFlag{ | |||
| Name: "wipe-all-configs", | |||
| Hidden: true, | |||
Contributor
Author
There was a problem hiding this comment.
i kept this hidden, but lmk if you feel strongly otherwise
ddworken
approved these changes
Apr 28, 2020
Contributor
|
LGTM 👍 I suspect you're right that the config file clearing didn't work correctly all along, so thanks for fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this ever worked, but my kssh config files were not getting deleted on
docker killof the keybaseca container. Issue #86 mentions the same problem. (Note my files do get properly deleted if I'm in the container and only kill the keybaseca process.)This is because
docker killsends a SIGKILL only to the process with pid1, and that process wasn't forwarding the signal to the keybaseca process. Adding--inittodocker runmakes it such that an init process based on tini is run as pid 1, that will properly reap zombie processes. But the problem here is that even if we are able to properly propagate the signal to keybaseca, keybaseca needs kbfsfuse to stay alive long enough to actually delete the config files. So at this point...I decided to try another approach of just starting another docker container to delete all config files, before killing all ca-related containers.make clean-ksshwill delete all config files that the CA Keybase account can find. This will only mess you up if for some reason, you have another CA bot simultaneously running that is listening on and signing keys for the same teams -- this seems really unlikely, and if you are in this situation, you can just restart your other CA bot to rewrite the kssh files.