This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Repository navigation
Add tests and docs for ping/pong interaction - #93
Merged
Merged
Conversation
ddworken
commented
Apr 23, 2020
| ) % (shlex.quote(path))) | ||
| # Sleep so keybaseca has time to start | ||
| time.sleep(5) | ||
| time.sleep(10) |
Contributor
Author
There was a problem hiding this comment.
Running the tests on my (slow) laptop had some intermittent failures with this, so just bumped it. It makes the tests a little slower but they're already slow enough so /shrug
mmou
reviewed
Apr 24, 2020
mmou
reviewed
Apr 24, 2020
mmou
suggested changes
Apr 24, 2020
mmou
left a comment
mmou
left a comment
Contributor
There was a problem hiding this comment.
thanks for this PR! just a couple things
Co-Authored-By: M Ember Mou <[email protected]>
Co-Authored-By: M Ember Mou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests and docs to go along with #50 (this code was a WIP on my laptop but just finished it up).