This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Repository navigation
Add KEYBASE_TIMEOUT configuration parameter to configure a custom timeout for interacting with the bot - #92
Merged
Conversation
Contributor
Author
|
@blaggacao can you give this a try and see whether tweaking the |
mmou
self-requested a review
April 23, 2020 19:25
…keybase timeouts In order to configure the timeouts for #91, we need to pull in the latest KB chat library which was updated here: keybase/go-keybase-chat-bot#67 The library also changed the arg order to a function, so swapped that in our code to make everything continue to work.
…eout for interacting with the bot
mmou
force-pushed
the
ddworken/increase-kb-chat-timeout
branch
from
April 23, 2020 20:14
510ac96 to
1bf98bb
Compare
Contributor
|
thanks for your work on this @ddworken! a heads up - aiming to get this in in the next hour just so it's easier for me to start on another PR that includes this PR's keybase version bump. |
mmou
approved these changes
Apr 23, 2020
Contributor
Author
|
Sounds good! Thanks for the heads up 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users (#91) were having difficulties with timeouts if running the CA bot on a slow computer with a high latency internet connection. In order to fix this, add a new configuration parameter that can be used to change the timeout. In order to do so, also had to update out dependencies to pull in the latest KB chat library (keybase/go-keybase-chat-bot#67).
The library also changed the arg order to a function, so swapped that in our code to make everything continue to work.
This changes the timeouts for KB chat and for the Keybase service, so it should also fix #90