Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Makefile add support for dockerhub image - #84

Merged
ddworken merged 2 commits into
keybase:masterfrom
krezreb:master
Apr 18, 2020
Merged

ddworken merged 2 commits into
keybase:masterfrom
krezreb:master

Conversation

@krezreb

@krezreb krezreb commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

Rather than having to build the docker image locally, setting an optional env var DOCKER_IMAGE will instead pull the image from dockerhub e.g.

export DOCKER_IMAGE=jbeeson/bot-certca
make generate

...

@ddworken

Copy link
Copy Markdown
Contributor

Thanks for the PR! LGTM 👍

@ddworken
ddworken merged commit 4cef409 into keybase:master Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants