Skip to content

Ninja code - #99

Merged
danipoma merged 3 commits into
javascript-tutorial:masterfrom
otmon76:1.3.4
Aug 22, 2022
Merged

danipoma merged 3 commits into
javascript-tutorial:masterfrom
otmon76:1.3.4

Conversation

@otmon76

@otmon76 otmon76 commented Jul 17, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jul 17, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 17, 2022 17:15
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Outdated

@danipoma danipoma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Otmon,

Please take a look at my suggestions.

Have a nice day.

@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label Aug 19, 2022
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Aug 19, 2022
@otmon76

otmon76 commented Aug 22, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Aug 22, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 22, 2022 15:14
@danipoma
danipoma merged commit b642f3e into javascript-tutorial:master Aug 22, 2022
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants