Repository navigation
fix(codeceval): honest empty diff reports; size cli: requests by channel - #476
Merged
Merged
Conversation
- Diff/text-diff reports name one of three empty states (no model, no same-tool pairs, N pairs that generated no question) instead of one conflated hint; the CLI passes the pair count. - request_tokens/oversized_arms follow the answer channel: a text backend is sized with _TEXT_INSTRUCTION and no tool definitions. - Pre-flight refusal wording branches on the answer channel. - Direct test for _codec_complete's legacy (trials - fails) fallback. - Correct the min_paired comment and _codec_turn docstring. Refs #450 Fixes #266
- The empty text-diff report names its own cause (no lossless text diff) instead of the JSON record-list advice. - Text-channel request sizing adds _CLI_PREAMBLE_TOKENS (3131, the figure recorded in fluency.cli_answerer; not re-measured). Refs #450
6 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_build_diff_style_reportnow names one of three empty states: no model configured / no same-tool pairs / N pairs that generated no question. The old single hint is gone. Newfluency.diff_pairs/fluency.text_diff_pairs(pulled out of the harnesses, so the pairing logic is unchanged) give the CLI the pair count. Part (b), committing a corpus, is being closed as obsolete.request_tokenscounts the tool-channel instruction and tool defs forcli:models. Now it follows the answer channel through a shared_channel_instruction, which_codec_turnalso uses. Theclaude -ppreamble part is not covered: still not counted, and the docstring says so._codec_completefallback branch: added a direct test (the_codec_answeredfallback was already pinned bytest_R7_legacy_rows_fall_back_to_trials_minus_fails).min_pairedcomment (report.py) now names_CODEC_MIN_QUESTIONS, and the_codec_turndocstring now notes theclaude -ppreamble.answer_channel.test_the_primer_counts_toward_the_terse_arms_input_limit(drivesrun_codec_fluency) andtest_an_UNSAFE_row_names_lost_calls_tooboth fail when their code is removed. No change needed._TEXT_INSTRUCTIONduplication (pending decision), and the mixed cli:/gateway SAFE-row compliance line.Test plan
uv run ruff check .: clean.uv run mypy: clean.uv run pytest -q: 2718 passed.Refs #450
Fixes #266