Skip to content

changes in (dataExport): ensure table updates to show correct file extension - #2978

Draft
AryanK37 wants to merge 2 commits into
ilastik:mainfrom
AryanK37:fix/export-table-extension
Draft

changes in (dataExport): ensure table updates to show correct file extension#2978
AryanK37 wants to merge 2 commits into
ilastik:mainfrom
AryanK37:fix/export-table-extension

Conversation

@AryanK37

@AryanK37 AryanK37 commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Bug Fix for Export with notifyDirty on All Slots

Fixes #2906

This PR fixes bug for export by applying notify dirty on slots to ExportPath So UI updates correctly when output changes.

However, updating all slots this way might cause performance issues, though I haven't observed any yet, expressed my concern and solution in this comment

I used a lambda function here because defining a separate function for this small task didn't seem necessary
However, if using a lambda doesn't look good, we can change it into a separate function, to improve readability or I can also add a comment explaining the approach

What this PR ensures is by using notifydirty through all slots bug is fixed (which is the simplest solution i can think of, if this is not the ideal solution then please ignore this PR)

Output on updating it shows updated extension(eg. tiff here) instead of .h5

Screenshot from 2025-03-20 19-30-20

Checklist

  • Reference relevant issues and other pull requests.

@codecov

codecov Bot commented Mar 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (fa9072e) to head (98ae599).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
- Coverage   57.25%   57.21%   -0.04%     
==========================================
  Files         536      536              
  Lines       62697    62698       +1     
  Branches     7759     7759              
==========================================
- Hits        35897    35875      -22     
- Misses      25015    25033      +18     
- Partials     1785     1790       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btbest

btbest commented Mar 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This seems to do the trick, and I think performance isn't a concern here. More than that, it just doesn't quite make sense to me why this works... It looks like the existing update in __init__ just above the code change should have taken care of it, and at the same time now I wonder why the paths do update even before this change when you make a change in the image export settings.

@AryanK37

AryanK37 commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

Somewhere it's not updating. The reason it works is because notifyDirty updates it. To pinpoint why it's not updating, I'll try to pinpoint it with print statements to proceed with better fix.

@AryanK37
AryanK37 marked this pull request as draft April 11, 2025 18:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Export table initially shows all export paths with ".h5" extension regardless of setting

2 participants

@AryanK37 @btbest