Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: bind outcome witness to expected action identity
  • Loading branch information
hippoley committed Oct 8, 2026
commit 92a35d6df752280b12671f929650390950938899
10 changes: 10 additions & 0 deletions skill_factory/evolution/outcome_witness.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def validate_outcome_witness(
payload: dict[str, Any],
*,
now: datetime | None = None,
expected_action_ref: dict[str, str] | None = None,
) -> None:
schema = json.loads(SCHEMA_PATH.read_text(encoding="utf-8"))
try:
Expand All @@ -51,6 +52,15 @@ def validate_outcome_witness(
prefix = f"{where}: " if where else ""
raise OutcomeWitnessError(f"{prefix}{exc.message}") from exc

if expected_action_ref is not None:
observed_ref = payload["action_ref"]
expected_type = expected_action_ref.get("type")
expected_id = expected_action_ref.get("id")
if observed_ref.get("type") != expected_type or observed_ref.get("id") != expected_id:
raise OutcomeWitnessError(
"action_ref does not match the action being evaluated"
)

observed_at = _parse_utc(payload["observed_at"])
current = now or datetime.now(timezone.utc)
if current.tzinfo is None:
Expand Down