Repository navigation
vault-23135 - fix modify storage keys ending with .temp causes overwr… - #25395
Merged
Merged
Conversation
github-actions
Bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
raskchanky
approved these changes
Feb 14, 2024
raskchanky
left a comment
raskchanky
left a comment
Collaborator
There was a problem hiding this comment.
I couldn't resist one tiny nitpick to plug my favorite testing function 😆. This looks great! Thanks for tackling this!
| if err != nil { | ||
| t.Fatalf("err: %s", err) | ||
| } | ||
| defer os.RemoveAll(dir) |
Collaborator
There was a problem hiding this comment.
This is super nitpicky, but if you use t.TempDir() here, you can avoid error handling and cleanup, as all of that is automatic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #23135
Instead of hardcoded
.tempsuffix, randomize the suffix to make sure it is not overwriting an existing file.