Repository navigation
UI: Fix KV v2 json editor - #24224
Merged
Merged
Conversation
github-actions
Bot
added
the
hashicorp-contributed-pr
|
Build Results: |
| super(...arguments); | ||
| this.originalSecret = JSON.stringify(this.args.secret.secretData || {}); | ||
| if (this.originalSecret.lastIndexOf('{') > 0) { | ||
| // Dumb way to check if there's a nested object in the secret |
hellobontempo
approved these changes
Nov 21, 2023
hellobontempo
left a comment
hellobontempo
left a comment
Contributor
There was a problem hiding this comment.
Nice work fixing this! 👏
fopina-ci
pushed a commit
to fopina/vault
that referenced
this pull request
Dec 1, 2023
) * Fix JSON editor in KVv2 unable to paste. Fixes hashicorp#23940 * Default to JSON view on edit with secret is complex * Add changelog
2 tasks done
2 tasks done
This was referenced May 20, 2024
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the KV V2 refactor, there was strange behavior when attempting to paste into the JSON editor as described in #23940. This PR fixes that issue, and restores previous behavior where the edit mode defaulted to JSON when the KV secret is "complex" (has nested objects within it).