chore(samples): update Autoclass Sample for v2.1 features - #2259
Merged
Merged
Conversation
BenWhitehead
added
do not merge
product-auto-label
Bot
added
size: s
cojenco
reviewed
Oct 16, 2023
cojenco
left a comment
cojenco
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this! Could we also update the storage_get_autoclass sample to demonstrate the newly added fields?
BenWhitehead
force-pushed
the
samples/autoclass
branch
from
October 27, 2023 17:22
79c92ab to
90a1ca3
Compare
product-auto-label
Bot
added
size: m
BenWhitehead
removed
the
do not merge
BenWhitehead
force-pushed
the
samples/autoclass
branch
from
October 27, 2023 17:25
90a1ca3 to
636e08f
Compare
Collaborator
Author
|
Now that libraries-bom has been released with the feature I've rebased and updated the sample and the samples test. @cojenco I applied the value changes in the sample you recommended. |
Contributor
LGTM, could we showcase the new fields in the get_autoclass sample too? Thank you @BenWhitehead |
BenWhitehead
force-pushed
the
samples/autoclass
branch
from
October 27, 2023 17:33
636e08f to
5c045d9
Compare
Co-authored-by: cojenco <[email protected]>
BenWhitehead
force-pushed
the
samples/autoclass
branch
from
October 27, 2023 17:41
5c045d9 to
ed980a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2258