Skip to content

feat: add auth input validation #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerop merged 1 commit into from
Sep 17, 2025
Merged

feat: add auth input validation #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,17 @@ outputs:
runs:
using: 'composite'
steps:
- name: 'Validate inputs'
shell: 'bash'
run: '${{ github.action_path }}/scripts/validate-inputs.sh'
env:
INPUT_GEMINI_API_KEY_PRESENT: '${{ inputs.gemini_api_key != '' }}'
INPUT_GOOGLE_API_KEY_PRESENT: '${{ inputs.google_api_key != '' }}'
INPUT_GCP_WORKLOAD_IDENTITY_PROVIDER_PRESENT: '${{ inputs.gcp_workload_identity_provider != '' }}'
INPUT_GCP_PROJECT_ID_PRESENT: '${{ inputs.gcp_project_id != '' }}'
INPUT_GCP_SERVICE_ACCOUNT_PRESENT: '${{ inputs.gcp_service_account != '' }}'
INPUT_USE_VERTEX_AI: '${{ inputs.use_vertex_ai }}'
INPUT_USE_GEMINI_CODE_ASSIST: '${{ inputs.use_gemini_code_assist }}'
- name: 'Configure Gemini CLI'
if: |-
${{ inputs.settings != '' }}
Expand Down
65 changes: 65 additions & 0 deletions scripts/validate-inputs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
#!/bin/bash
set -euo pipefail

Comment thread
jerop marked this conversation as resolved.
# Auth inputs (as boolean presence flags)
gemini_api_key_present="${INPUT_GEMINI_API_KEY_PRESENT:-false}"
google_api_key_present="${INPUT_GOOGLE_API_KEY_PRESENT:-false}"
gcp_workload_identity_provider_present="${INPUT_GCP_WORKLOAD_IDENTITY_PROVIDER_PRESENT:-false}"
Comment thread
jerop marked this conversation as resolved.
gcp_project_id_present="${INPUT_GCP_PROJECT_ID_PRESENT:-false}"
gcp_service_account_present="${INPUT_GCP_SERVICE_ACCOUNT_PRESENT:-false}"
Comment thread
jerop marked this conversation as resolved.

# Other inputs (values needed)
Comment thread
jerop marked this conversation as resolved.
use_vertex_ai="${INPUT_USE_VERTEX_AI:-false}"
use_gemini_code_assist="${INPUT_USE_GEMINI_CODE_ASSIST:-false}"

# Count number of auth methods
auth_methods=0
if [[ "${gemini_api_key_present}" == "true" ]]; then ((auth_methods++)); fi
if [[ "${google_api_key_present}" == "true" ]]; then ((auth_methods++)); fi
if [[ "${gcp_workload_identity_provider_present}" == "true" ]]; then ((auth_methods++)); fi

if [[ ${auth_methods} -eq 0 ]]; then
echo "::error title=Configuration error::No authentication method provided. Please provide one of 'gemini_api_key', 'google_api_key', or 'gcp_workload_identity_provider'." >&2
exit 1
fi

if [[ ${auth_methods} -gt 1 ]]; then
echo "::error title=Configuration error::Multiple authentication methods provided. Please use only one of 'gemini_api_key', 'google_api_key', or 'gcp_workload_identity_provider'." >&2
exit 1
fi

# WIF validation
if [[ "${gcp_workload_identity_provider_present}" == "true" ]]; then
if [[ "${gcp_project_id_present}" != "true" || "${gcp_service_account_present}" != "true" ]]; then
echo "::error title=Configuration error::When using Workload Identity Federation ('gcp_workload_identity_provider'), you must also provide 'gcp_project_id' and 'gcp_service_account'." >&2
exit 1
fi
if [[ "${use_vertex_ai}" != "true" && "${use_gemini_code_assist}" != "true" ]]; then
echo "::error title=Configuration error::When using Workload Identity Federation, you must set either 'use_vertex_ai' or 'use_gemini_code_assist' to 'true'." >&2
Comment thread
jerop marked this conversation as resolved.
exit 1
fi
if [[ "${use_vertex_ai}" == "true" && "${use_gemini_code_assist}" == "true" ]]; then
echo "::error title=Configuration error::'use_vertex_ai' and 'use_gemini_code_assist' cannot both be 'true'." >&2
exit 1
fi
fi

# Vertex AI API Key validation
if [[ "${google_api_key_present}" == "true" ]]; then
if [[ "${use_vertex_ai}" != "true" ]]; then
echo "::error title=Configuration error::When using 'google_api_key', you must set 'use_vertex_ai' to 'true'." >&2
exit 1
fi
if [[ "${use_gemini_code_assist}" == "true" ]]; then
echo "::error title=Configuration error::'use_gemini_code_assist' cannot be 'true' when using 'google_api_key'." >&2
exit 1
fi
fi

# Gemini API Key validation
if [[ "${gemini_api_key_present}" == "true" ]]; then
if [[ "${use_vertex_ai}" == "true" || "${use_gemini_code_assist}" == "true" ]]; then
echo "::error title=Configuration error::When using 'gemini_api_key', both 'use_vertex_ai' and 'use_gemini_code_assist' must be 'false'." >&2
exit 1
fi
fi
Loading