Skip to content

chore(logging): only enable Gemini debug when DEBUG is set - #180

Merged
sethvargo merged 1 commit into
mainfrom
sethvargo/debug
Aug 13, 2025
Merged

sethvargo merged 1 commit into
mainfrom
sethvargo/debug

Conversation

@sethvargo

Copy link
Copy Markdown
Contributor

This is a follow-up to #178 which sets the Gemini CLI debug settings.

This is a follow-up to #178 which sets the Gemini CLI debug settings.
@sethvargo
sethvargo requested review from a team as code owners August 13, 2025 20:18
@sethvargo
sethvargo enabled auto-merge (squash) August 13, 2025 20:18

@gemini-cli gemini-cli Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change! It makes the debug logging configurable, which is much better than having it hardcoded. Thanks for this improvement!

@leehagoodjames leehagoodjames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cleaner, but it makes debug logging not enabled by default for users - right?

Is there a way that we can keep that - so that their issues & logging is more informative, or do we expected #180 to do this sufficiently?

@sethvargo
sethvargo merged commit 772c555 into main Aug 13, 2025
@sethvargo
sethvargo deleted the sethvargo/debug branch August 13, 2025 22:00
@sethvargo

Copy link
Copy Markdown
Contributor Author

I think #180 will fully capture error messages. When a user reports a bug, we can ask them to re-run the workflow with debug logging enabled (it's a checkbox is the UI):

CleanShot 2025-08-13 at 21 12 22@2x

That will also enable the debug logs for gemini.

google-github-actions-bot added a commit that referenced this pull request Aug 14, 2025
## What's Changed
* Highlight core tools and mcp servers in configuration docs by @jerop
in #160
* feat(/review): support pull_request_review &
pull_request_review_comment events by @leehagoodjames in
#161
* Github-workflow to automate validation of new PRs based on
Contribution Guidelines of the repository by @jasmeetsb in
#162
* fix: Update gemini-issue-automated-triage.yml by @teolemon in
#165
* Add instruction for code review limit. by @aliciatang07 in
#168
* feat(logging): Enable debug logging across all workflows and
gemini-cli by @leehagoodjames in
#178
* feat(workflows): reduce restrictions for invoking workflows for
private repos by @leehagoodjames in
#177
* fix(runner): capture stderr and stdout after command finishes by
@sethvargo in
#183
* chore(logging): only enable Gemini debug when DEBUG is set by
@sethvargo in
#180
* feat: improve gemini issue triage workflow by @jerop in
#171

## New Contributors
* @jasmeetsb made their first contribution in
#162
* @teolemon made their first contribution in
#165

**Full Changelog**:
v0.1.10...v0.1.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants