Repository navigation
test(core): skip windows quoting integration test when pwsh.exe is not available - #29647
supunyasanthaofficial wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the stability of the core shell execution integration tests on Windows. By restricting the execution of tests that specifically require PowerShell 7 to environments where it is available, it prevents false negatives in environments relying on Windows PowerShell 5.1. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/XS
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Windows integration tests for ShellExecutionService to conditionally skip tests based on the presence of pwsh.exe rather than just checking if the operating system is Windows. It imports resolveExecutable to verify the availability of pwsh.exe and updates the test suite's skip condition accordingly. There are no review comments, and I have no feedback to provide.
gemini-cli
Bot
added
the
area/platform
This branch has not been deployed
1 participant
Fixes #29646
Summary
Guards
shellExecutionService.windows.integration.test.tsso that it is skipped when PowerShell 7 (pwsh.exe) is not available on Windows.As documented in the test comments, these tests require
pwsh.exeto preserve inline double quotes through native executable invocation and fail when routing through Windows PowerShell 5.1.Using
const hasPwsh = isWindows && Boolean(resolveExecutable('pwsh.exe'))ensures that environments without PowerShell 7 installed cleanly skip the suite, avoiding test failures on standard Windows setups while continuing to execute in CI.