Repository navigation
Update frugalReads.eval.ts - #29630
MaddipatlaChetan24 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an off-by-one error in the frugalReads evaluation suite. By adjusting the expected error line numbers to account for 1-based indexing, the test now correctly validates that the agent reads the intended lines in the generated fixture, ensuring accurate coverage checks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/XS
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the test in evals/frugalReads.eval.ts to correct the line numbers being verified from [500, 510, 520] to [501, 511, 521]. It also adds a comment explaining that the generated file is 1-indexed, meaning the loop indices correspond to lines 501, 511, and 521. I have no feedback to provide as there are no review comments.
🛑 Action Required: Evaluation ApprovalSteering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged. Maintainers:
Once approved, the evaluation results will be posted here automatically. |
GitHub Actions
Waiting
gemini-cli
Bot
added
the
status/need-issue
This branch is waiting to be deployed
1 participant
Summary
Fixes an off-by-one in the "nearby lines" frugal-reads eval. It checked that lines 500/510/520 were read, but the generated
varlines are lines 501/511/521 (1-indexed, as ESLint reports them), so a tight read of exactly those lines would fail the check.Details
The fixture is built from a 0-based loop (
i === 500 || i === 510 || i === 520), but file lines are 1-indexed. ChangederrorLinesfrom[500, 510, 520]to[501, 511, 521]. Eval-only change; no product code touched.Related Issues
None.
How to Validate
varlines. Expected:[501, 511, 521].frugalReadseval suite.Not run against the eval rig (needs live model calls); the line numbers were verified by regenerating the fixture.
Pre-Merge Checklist