Repository navigation
Conversation
Bare --resume (and --resume latest) picked the most recently started session by startTime, so returning to an earlier session and later resuming reopened a stale one instead of the session just left. Select by lastUpdated, which the recorder updates on every turn.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the behavior of the '--resume' flag in the CLI. Previously, the system would resume the session with the most recent start time, which often led to users incorrectly resuming stale 'spike' sessions instead of their primary, active session. The logic has been updated to correctly identify the most recently active session, ensuring a more intuitive experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/M
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the session resolution logic in packages/cli/src/utils/sessionUtils.ts to determine the 'latest' session based on the most recent activity (lastUpdated) rather than the session start time (startTime). It also adds a corresponding unit test in packages/cli/src/utils/sessionUtils.test.ts to verify this behavior. There are no review comments, and I have no feedback to provide.
gemini-cli
Bot
added
priority/p2
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
1 participant
Bare --resume picked the session with the newest start time, so users with a long-lived main session plus a newer spike resumed into the stale spike. Latest now resolves by most recent activity.
Verified: new test fails before and passes after, neighbors green.
Fixes #29410