Repository navigation
fix(vscode-ide-companion): track all activate() Disposables in subscriptions - #29190
Frank20021 wants to merge 1 commit into
Conversation
…iptions Comma expressions in context.subscriptions.push() dropped the gemini.diff.accept command and onDidChangeWorkspaceFolders listener, so they were never disposed on deactivation. Co-authored-by: Cursor <[email protected]>
|
📊 PR Size: size/M
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a resource management bug in the VS Code extension activation logic. By removing incorrect grouping of registrations, it ensures that all command and workspace event listeners are properly registered and subsequently disposed of, preventing common VS Code extension issues like command name collisions and memory leaks during reload. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up redundant parentheses around several VS Code API calls (such as registerCommand and onDidChangeWorkspaceFolders) when pushing them to context.subscriptions in extension.ts. Additionally, it updates the vscode mock in extension.test.ts to return mock disposable objects for these subscriptions and adds a new unit test to verify that the subscriptions are correctly tracked in the extension context. I have no feedback to provide.
gemini-cli
Bot
added
priority/p2
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
1 participant
Summary
activate()where wrapping two registrations in parentheses meant only the last Disposable of each pair was pushed tocontext.subscriptions.gemini.diff.acceptandonDidChangeWorkspaceFoldersare disposed on deactivation (avoids "command already exists" on reload and stale workspace-folder listeners).context.subscriptions(existingtoHaveBeenCalled()checks could not catch this).Fixes #27790
Test plan
npm run test --workspace=gemini-cli-vscode-ide-companion -- src/extension.test.ts(12 passed)gemini.diff.acceptdoes not throw "already exists"Made with Cursor