Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
📊 PR Size: size/L
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the available Gemini model repertoire by registering several new flash variants and updating the default flash model target to gemini-3.8-flash for eligible users. The changes include updates to core configurations, CLI UI components, and test suites to ensure consistent behavior and support for these new models while maintaining existing manual selection capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the default Gemini Flash model from gemini-3.5-flash to gemini-3.8-flash across configuration files, schemas, tests, and UI components, and registers several new Gemini 3.x Flash models. The review feedback correctly identifies that the alternative name for the 3.5 Flash model (SECONDARY_GEMINI_3_5_FLASH_MODEL / 'gemini-3-flash') was omitted from the override exclusion check in resolveModel, which would cause manual selections of this model to be overridden. It is recommended to update this check and add a corresponding test case using hardcoded literal values to prevent regressions.
| normalizedModel !== PREVIEW_GEMINI_FLASH_MODEL && | ||
| normalizedModel !== DEFAULT_GEMINI_3_5_FLASH_MODEL && | ||
| normalizedModel !== GEMINI_3_5_FLASH_LITE_MODEL && | ||
| normalizedModel !== GEMINI_3_6_FLASH_MODEL && | ||
| normalizedModel !== GEMINI_3_7_FLASH_MODEL && | ||
| normalizedModel !== GEMINI_3_8_FLASH_MODEL |
There was a problem hiding this comment.
The alternative name for the 3.5 Flash model (SECONDARY_GEMINI_3_5_FLASH_MODEL / 'gemini-3-flash') is not excluded from the override check. This causes explicit manual selections of 'gemini-3-flash' to be silently redirected to gemini-3.8-flash when useGemini3_5Flash is active, violating the goal of preserving explicit manual selections of 3.5/3.6/3.7/3.8 flash models.
normalizedModel !== PREVIEW_GEMINI_FLASH_MODEL &&
normalizedModel !== DEFAULT_GEMINI_3_5_FLASH_MODEL &&
normalizedModel !== SECONDARY_GEMINI_3_5_FLASH_MODEL &&
normalizedModel !== GEMINI_3_5_FLASH_LITE_MODEL &&
normalizedModel !== GEMINI_3_6_FLASH_MODEL &&
normalizedModel !== GEMINI_3_7_FLASH_MODEL &&
normalizedModel !== GEMINI_3_8_FLASH_MODEL| expect( | ||
| resolveModel( | ||
| DEFAULT_GEMINI_3_5_FLASH_MODEL, | ||
| false, | ||
| false, | ||
| true, | ||
| undefined, | ||
| true, | ||
| ), | ||
| ).toBe(DEFAULT_GEMINI_3_5_FLASH_MODEL); |
There was a problem hiding this comment.
Add a test case to verify that explicit manual selections of the alternative 3.5 Flash model name ('gemini-3-flash') are preserved and not overridden when useGemini3_5Flash is active. In accordance with our testing guidelines, use hardcoded literal values instead of importing constants to ensure tests are self-contained and less brittle.
| expect( | |
| resolveModel( | |
| DEFAULT_GEMINI_3_5_FLASH_MODEL, | |
| false, | |
| false, | |
| true, | |
| undefined, | |
| true, | |
| ), | |
| ).toBe(DEFAULT_GEMINI_3_5_FLASH_MODEL); | |
| expect( | |
| resolveModel( | |
| 'gemini-3.5-flash', | |
| false, | |
| false, | |
| true, | |
| undefined, | |
| true, | |
| ), | |
| ).toBe('gemini-3.5-flash'); | |
| expect( | |
| resolveModel( | |
| 'gemini-3-flash', | |
| false, | |
| false, | |
| true, | |
| undefined, | |
| true, | |
| ), | |
| ).toBe('gemini-3-flash'); |
References
- In tests, prefer using hardcoded literal values instead of importing constants to ensure tests are self-contained and less brittle.
|
…rollout
SECONDARY_GEMINI_3_5_FLASH_MODEL ('gemini-3-flash') was missing from the
override-exclusion list in resolveModel(), so explicitly selecting it while
the flash GA rollout is active silently redirected to the default flash
model instead of preserving the user's choice, same as the other flash
aliases.
0a7e0c0 to
5aec0a2
Compare
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
Summary
gemini-3.5-flash-lite,gemini-3.6-flash,gemini-3.7-flash, andgemini-3.8-flashas valid, selectable Gemini models (constants,VALID_GEMINI_MODELS,defaultModelConfigs.tsaliases/definitions/resolutions).gemini-3.8-flashto the default flash model returned once the flash GA rollout experiment (hasGemini35FlashGAAccess) is active, replacinggemini-3.5-flashin that role.Test plan
npx tsc --noEmit(core + cli) passesnpm run lintpasses with zero warningsmodels.test.ts,defaultModelConfigs,modelConfigService.test.ts,config.test.ts,coreToolsModelSnapshots.test.ts, andavailability/*suites pass (480 tests)docs/reference/configuration.mdandschemas/settings.schema.jsonfrom the updated model configs🤖 Generated with Claude Code