Repository navigation
Conversation
…migration Claude Code measures hook timeouts in seconds (default 60), while Gemini CLI's hook runner interprets the value as milliseconds (DEFAULT_HOOK_TIMEOUT = 60000). The migration copied the number verbatim, so a migrated "timeout": 30 became 30ms instead of 30s. Fixes google-gemini#29122
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where hook timeouts were incorrectly migrated from Claude to Gemini CLI. Because the two systems measure timeouts in different units (seconds vs. milliseconds), the previous implementation caused hooks to time out prematurely. The changes ensure that migrated timeout values are correctly scaled to milliseconds during the migration process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the hook migration logic to convert timeout values from seconds (used by Claude) to milliseconds (used by Gemini). It modifies the migration implementation in migrate.ts to multiply the timeout value by 1000, and updates the corresponding unit tests in migrate.test.ts to assert the converted millisecond values. There are no review comments, so I have no feedback to provide.
gemini-cli
Bot
added
priority/p2
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
Thanks for the policy note. This PR fixes #29122, a triaged P2 bug ( |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
1 participant
Fixes #29122.
Claude Code measures hook timeouts in seconds (default 60), while Gemini CLI's hook runner interprets the value as milliseconds (
DEFAULT_HOOK_TIMEOUT = 60000inpackages/core/src/hooks/hookRunner.ts). The migration copied the number verbatim, so a migrated"timeout": 30became 30 ms instead of 30 s — the hook would time out almost instantly.Changes
packages/cli/src/commands/hooks/migrate.ts: multiply the migrated timeout by 1000 and correct the unit commentpackages/cli/src/commands/hooks/migrate.test.ts: update the two existing assertions that encoded the buggy behavior (30→30000) and rework the preserve-timeout test to verify the seconds→milliseconds conversion (60→60000)Testing
npx vitest run src/commands/hooks/migrate.test.ts— 17/17 passnpm run typecheck(cli package) and eslint on the changed files — clean