Repository navigation
fix(a2a-server): remove misleading security schemes and hardcoded credentials - #29067
CheesyWannabe wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up the a2a-server configuration by removing misleading security schemes and insecure hardcoded credentials. These changes ensure that the service metadata and authentication logic accurately reflect the intended unauthenticated state for local development, reducing potential confusion and security risks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the basic and bearer authentication configurations (securitySchemes and security) from the coderAgentCard and simplifies the customUserBuilder function in packages/a2a-server/src/http/app.ts to always return an unauthenticated user. I have no feedback to provide as there are no review comments.
gemini-cli
Bot
added
the
priority/p1
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
gemini-cli
Bot
added
priority/p2
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
2 participants
Fixes #29001.
Summary of Changes
coderAgentCard: Removed misleadingsecuritySchemesandsecurityrequirements so the agent metadata accurately reflects that endpoints are unauthenticated by design for local development.customUserBuilder: Stripped out the insecure, hardcoded public credentials ('valid-token','admin:password').Testing
146tests across15test files) pass successfully with these changes.