Repository navigation
[SSR Agent] Issue Fix (26120): Clarify privacy notice wording and selection options - #28820
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses misleading and contradictory wording in the privacy notice. By refining the labels for the data collection permission options and providing clearer instructions, the changes ensure that users have a transparent understanding of how their data is used for product improvement. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/M
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CloudFreePrivacyNotice component to use more descriptive opt-in and opt-out selection labels, adds an explanatory paragraph about data usage, and includes a test case to verify these changes. Feedback is provided regarding the length of the new labels, which may be truncated on standard 80-column terminals; it is recommended to use a custom renderItem to wrap the text instead of truncating it.
gemini-cli
Bot
added
priority/p2
…p selection options $fixes google-gemini#26120 Original Issue URL: google-gemini#26120 ### Context & Problem The privacy notice wording was ambiguous and confusing. The introductory text stated that users could opt out below, but the actual available options under the RadioButtonSelect toggle were simply "Yes" and "No". Furthermore, because longer explicit labels can exceed standard 80-column terminal widths, default `wrap="truncate"` on `RadioButtonSelect` would truncate the critical `(Opt-in)` and `(Opt-out)` suffixes. ### Detailed Changes - Modified [CloudFreePrivacyNotice.tsx](file:///usr/local/google/home/joneba/ssr-prototype/gcli-intern-project/packages/cli/src/ui/privacy/CloudFreePrivacyNotice.tsx): - Updated selection items' labels to explicitly state `"Yes, grant permission to use my data for product improvement (Opt-in)"` and `"No, deny permission to use my data for product improvement (Opt-out)"`. - Aligned explanatory notice text to describe how to opt-in or opt-out. - Refined prompt question to `"Allow Google to use this data to develop and improve our products and services?"`. - Added a custom `renderItem` function with `wrap="wrap"` on `RadioButtonSelect` to ensure full text wrapping on 80-column terminals without truncation. - Updated tests in [CloudFreePrivacyNotice.test.tsx](file:///usr/local/google/home/joneba/ssr-prototype/gcli-intern-project/packages/cli/src/ui/privacy/CloudFreePrivacyNotice.test.tsx): - Added unit test asserting `renderItem` is provided to `RadioButtonSelect` and configures `wrap="wrap"` for all items. ### Verification - Verified that all unit tests in `packages/cli/src/ui/privacy/CloudFreePrivacyNotice.test.tsx` pass successfully using Vitest.
dd03573 to
e597eb3
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the CloudFreePrivacyNotice component to provide more descriptive labels for the opt-in and opt-out choices, along with an explanatory paragraph. It also implements a custom renderItem function for the RadioButtonSelect component to ensure the longer option text wraps correctly without truncation. A corresponding unit test has been added to verify this behavior. There are no review comments, so I have no feedback to provide.
2 participants
fixes #26120
Original Issue URL: #26120
Context & Problem
The privacy notice wording was misleading and contradictory. The introductory text stated that users could opt out below, but the actual available options under the RadioButtonSelect toggle were simply "Yes" and "No", creating inconsistent and confusing framing regarding data collection permission tracking.
Detailed Changes
Verification
packages/cli/src/ui/privacy/CloudFreePrivacyNotice.test.tsxpass successfully using Vitest.