[SSR Agent] Issue Fix (21911): Add composite flag to packages/cli tsconfig by joneba-google · Pull Request #28813 · google-gemini/gemini-cli

joneba-google · 2026-08-14T20:56:16Z

fixes #21911
Original Issue: #21911

Context & Problem

Running the root build or typecheck process failed because evals/tsconfig.json references ../packages/cli. However, packages/cli did not have "composite": true configured in its tsconfig.json, violating TypeScript's project references requirement.

Detailed Changes

packages/cli/tsconfig.json: Enabled "composite": true under compilerOptions so it can be referenced by other TypeScript projects.
package.json: Added a helper script "typecheck:verify": "tsc -b evals/tsconfig.json" to easily verify TypeScript project referencing and compilation.
evals/tsconfig.json: Reformatted the references block across multiple lines for better readability.

Verification

Verified that all TSConfigs are clean and correctly resolve.
Confirmed there are no ESLint issues in the modified files.

gemini-code-assist · 2026-08-14T20:56:24Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build failure in the root typecheck process caused by missing composite configuration in the CLI package. By enabling the composite flag and adding a dedicated verification script, the changes ensure that TypeScript project references are correctly resolved and maintainable.

Highlights

TypeScript Configuration: Enabled 'composite: true' in packages/cli/tsconfig.json to satisfy project reference requirements.
Build Verification: Added a new 'typecheck:verify' script to package.json to simplify TypeScript project reference validation.
Code Formatting: Reformatted the references block in evals/tsconfig.json for improved readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-08-14T20:56:30Z

📊 PR Size: size/XS

Lines changed: 3
Additions: +2
Deletions: -1
Files changed: 1

google-cla · 2026-08-14T20:56:34Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request formats the references array in evals/tsconfig.json, adds a new typecheck:verify script to package.json to run typechecking on the evals configuration, and enables the composite compiler option in packages/cli/tsconfig.json. I have no feedback to provide.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

github-actions · 2026-08-14T20:57:44Z

You already have 7 pull requests open. Please work on getting existing PRs merged before opening more.

github-actions · 2026-08-14T20:57:54Z

🛑 Action Required: Evaluation Approval

Steering changes have been detected in this PR. To prevent regressions, a maintainer must approve the evaluation run before this PR can be merged.

Maintainers:

Go to the Workflow Run Summary.
Click the yellow 'Review deployments' button.
Select the 'eval-gate' environment and click 'Approve'.

Once approved, the evaluation results will be posted here automatically.

adamfweidman

address comment otherwise LGTM

…onfig $fixes google-gemini#21911 Original Issue: google-gemini#21911 ### Context & Problem Running the root build or typecheck process failed because `evals/tsconfig.json` references `../packages/cli`. However, `packages/cli` did not have `"composite": true` configured in its `tsconfig.json`, violating TypeScript's project references requirement. ### Detailed Changes - **packages/cli/tsconfig.json**: Enabled `"composite": true` under compilerOptions so it can be referenced by other TypeScript projects. - **evals/tsconfig.json**: Formatted the references block for project references. ### Verification - Verified that all TSConfigs are clean and correctly resolve. - Ran `npm run typecheck` and `npm run build` to verify full compilation.

joneba-google requested review from a team as code owners August 14, 2026 20:56

github-actions Bot added the size/xs An extra small PR label Aug 14, 2026

gemini-code-assist Bot reviewed Aug 14, 2026

View reviewed changes

github-actions Bot closed this Aug 14, 2026

joneba-google had a problem deploying to eval-gate August 14, 2026 20:57 — with GitHub Actions Error

joneba-google requested review from DavidAPierce and adamfweidman August 14, 2026 20:59

joneba-google reopened this Aug 14, 2026

joneba-google had a problem deploying to eval-gate August 14, 2026 21:00 — with GitHub Actions Error

gemini-cli Bot added priority/p1 Important and should be addressed in the near term. area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt labels Aug 14, 2026

adamfweidman reviewed Aug 14, 2026

View reviewed changes

Comment thread package.json Outdated

adamfweidman approved these changes Aug 14, 2026

View reviewed changes

joneba-google closed this Aug 14, 2026

joneba-google reopened this Aug 14, 2026

joneba-google had a problem deploying to eval-gate August 14, 2026 23:24 — with GitHub Actions Failure

joneba-google force-pushed the ssr-agent-21911 branch from 39afd30 to 19fc918 Compare August 15, 2026 00:36

github-actions Bot mentioned this pull request Aug 15, 2026

📊 AI CLI 工具社区动态日报 2026-08-15 96loveslife/big_model_radar#327

Open

joneba-google force-pushed the ssr-agent-21911 branch from 19fc918 to b0345ec Compare August 16, 2026 19:07

joneba-google added this pull request to the merge queue Aug 16, 2026

Merged via the queue into google-gemini:main with commit 9a15c45 Aug 16, 2026
33 checks passed

joneba-google deleted the ssr-agent-21911 branch August 16, 2026 19:44

This was referenced Aug 17, 2026

📊 AI CLI 工具社区动态日报 2026-08-17 96loveslife/big_model_radar#337

Open

📊 AI CLI 工具社区动态日报 2026-08-18 litang9/big_model_radar#378

Open

Navigation Menu

Repository navigation

[SSR Agent] Issue Fix (21911): Add composite flag to packages/cli tsconfig - #28813

[SSR Agent] Issue Fix (21911): Add composite flag to packages/cli tsconfig#28813
joneba-google merged 1 commit into
google-gemini:mainfrom
JonE01:ssr-agent-21911

joneba-google commented Aug 14, 2026

Uh oh!

gemini-code-assist Bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

google-cla Bot commented Aug 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

adamfweidman left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

joneba-google commented Aug 14, 2026

Context & Problem

Detailed Changes

Verification

Uh oh!

gemini-code-assist Bot commented Aug 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla Bot commented Aug 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛑 Action Required: Evaluation Approval

Uh oh!

Uh oh!

adamfweidman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Aug 14, 2026 •

edited

Loading

github-actions Bot commented Aug 14, 2026 •

edited

Loading