Skip to content

fix(security): prevent supply chain RCE in eval-pr workflows - #28740

Closed
alifakbxr wants to merge 2 commits into
google-gemini:mainfrom
alifakbxr:fix/28336-rce-pull-request-target
Closed

alifakbxr wants to merge 2 commits into
google-gemini:mainfrom
alifakbxr:fix/28336-rce-pull-request-target

Conversation

@alifakbxr

Copy link
Copy Markdown

This PR fixes a critical security issue where untrusted fork code could execute in a privileged pull_request_target context (Issue #28336). It splits the eval workflow into a secure pull_request build step and a trusted workflow_run execution step.

Refs: google-gemini#28336

- Removes the unsafe eval-pr.yml which used pull_request_target
- Replaces with eval-pr-build.yml (pull_request) for untrusted build
- Replaces with eval-pr-run.yml (workflow_run) for trusted execution using build artifacts
@alifakbxr
alifakbxr requested a review from a team as a code owner August 9, 2026 02:34
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the size/l A large sized PR label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

📊 PR Size: size/L

  • Lines changed: 462
  • Additions: +251
  • Deletions: -211
  • Files changed: 3

- Pin actions/upload-artifact to v4 hash
- Fix template injections by moving ${{ }} interpolations to env variables
- Add zizmor ignore for safe workflow_run trigger
@gemini-cli

gemini-cli Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'.

This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

@gemini-cli

gemini-cli Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

@gemini-cli gemini-cli Bot closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Issues related to security size/l A large sized PR status/pr-nudge-sent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants