Skip to content

security: gate chained E2E on same-repository checkout for workflow_run - #27780

Closed
DVHRMNTCBSL wants to merge 1 commit into
google-gemini:mainfrom
DVHRMNTCBSL:security/chained-e2e-fork-guard
Closed

DVHRMNTCBSL wants to merge 1 commit into
google-gemini:mainfrom
DVHRMNTCBSL:security/chained-e2e-fork-guard

Conversation

@DVHRMNTCBSL

Copy link
Copy Markdown

Fork PR workflow_run chains can supply attacker-controlled repository + sha via artifact metadata while GEMINI_API_KEY is mounted in chained_e2e.yml jobs.

This PR skips Linux/macOS/Windows/evals jobs that checkout parse_run_context.outputs.repository when that repository is not github.repository.

Before: External fork can influence checkout ref/repo in jobs with GEMINI_API_KEY.
After: Only same-repo workflow_run / dispatch paths run secret-backed E2E.

@DVHRMNTCBSL
DVHRMNTCBSL requested a review from a team as a code owner June 10, 2026 04:24
@google-cla

google-cla Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the size/xs An extra small PR label Jun 10, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XS

  • Lines changed: 5
  • Additions: +5
  • Deletions: -0
  • Files changed: 1

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Jun 10, 2026
@gemini-cli

gemini-cli Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'.

This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

@rmedranollamas

Copy link
Copy Markdown
Contributor

Closing this pull request as it does not have an associated tracked issue linked, and there has been no progress since the nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs An extra small PR status/need-issue Pull requests that need to have an associated issue. status/pr-nudge-sent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants