Repository navigation
test: add more tests for AskUser - #17720
Conversation
|
Hi @jackwotherspoon, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jackwotherspoon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly boosts the test coverage for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the test coverage for the ask-user functionality, addressing previous feedback. The changes include exporting AskUserActionsContext to facilitate state capture in tests, adding an integration test in AppContainer.test.tsx to verify message bus communication for ASK_USER_REQUEST, and introducing a new test suite in ToolGroupMessage.test.tsx to thoroughly test the filtering logic for ask_user tool calls based on their status. The new tests are well-structured and cover the intended scenarios, enhancing the robustness of the feature.
|
Size Change: -6 B (0%) Total Size: 23.5 MB ℹ️ View Unchanged
|
jackwotherspoon
changed the title
gemini-cli
Bot
added
area/core
3 participants
Summary
This PR improves testing coverage for the
ask-userfunctionality, addressing feedback from PR #17411. It addsintegration tests for message bus communication and unit tests for tool group filtering logic.
Description
packages/cliAskUserActionsContextfromAskUserActionsContext.tsxto enable state capture intests.
AppContainer.test.tsxthat simulates anASK_USER_REQUESTbeing published on the message bus and verifies that the application state updates to show the dialog.
ToolGroupMessage.test.tsxto verify:ask_usertool calls are filtered out of the history log while in progress (Pending, Executing,Confirming).
ask_usertool calls remain visible once they reach a terminal state (Success, Error).Related Issues
Part of #17682
How to Validate
Verified the changes by running the affected test files:
npm test -w @google/gemini-cli -- src/ui/AppContainer.test.tsx src/ui/components/messages/ToolGroupMessage.test.tsxPre-Merge Checklist