Repository navigation
fix: point install hint at agent-governance-toolkit-core - #187
Open
thecvcodes wants to merge 1 commit into
Open
thecvcodes wants to merge 1 commit into
thecvcodes wants to merge 1 commit into
Conversation
agentmesh-platform is deprecated; agentmesh now ships in agent-governance-toolkit-core. Update the error/warning messages, docstrings and sample README, and replace the stubbed _setup test with ones that block the real agentmesh import. Fixes google#186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
Summary
AgentGovernancePlugintells users topip install agentmesh-platformwhenagentmeshcan't be imported. That package is deprecated;agentmeshnow ships inagent-governance-toolkit-core.agentmesh-platformwithagent-governance-toolkit-corein the plugin's error and warning messages, its docstrings, andcontributing/samples/agent_governance/README.md. The replacements are in place, with no other reformatting.test_raises_import_error_when_agentmesh_missing. It patched_setupto raise a mockedImportError, so it only asserted on the mock's own message and never exercised the plugin's. The new test blocks the realagentmeshimport through ablock_agentmeshfixture and asserts on the actual message.test_fail_open_warns_with_install_hint_when_agentmesh_missingto cover thefail_open=Truewarning.The fixture removes any loaded
agentmesh*modules and setssys.modules["agentmesh"] = None. Both tests therefore pass whether or not AGT is installed, even if it was imported earlier in the session.Testing plan
InMemoryRunnerwith the plugin in an environment without AGT, for bothfail_openmodes, and check the user-facing text.pytest results
tests/pluginsisn't part of the CI run (pytest tests/unittests), so the results above are from a local run on Python 3.11.tests/unittestsneededgreenletinstalled locally:test_hitl_approval_api.pyfails to collect onmainwithout it, because thehitlextra doesn't pull it in. That's unrelated to this change.E2E: Runner without AGT installed