Repository navigation
refactor(group-ldap-links): migrate group ldap links processor to python-gitlab - #1428
Merged
rickbrouwer merged 3 commits intoSep 28, 2026
Merged
Conversation
rickbrouwer
requested review from
TimKnight01,
amimas and
gdubicki
as code owners
September 14, 2026 15:54
rickbrouwer
had a problem deploying
to
Integrate Pull Request
September 14, 2026 15:54 — with 
GitHub Actions
Error
GitHub Actions
Error
rickbrouwer
had a problem deploying
to
Integrate Pull Request
September 14, 2026 15:54 — with
GitHub Actions
Error
GitHub Actions
Error
rickbrouwer
force-pushed
the
refactor-5-group-ldap-links
branch
from
September 14, 2026 15:57
23dda97 to
ededc74
Compare
rickbrouwer
had a problem deploying
to
Integrate Pull Request
September 14, 2026 15:57 — with
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
had a problem deploying
to
Integrate Pull Request
September 14, 2026 15:57 — with
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
marked this pull request as draft
September 14, 2026 17:20
…hon-gitlab Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
refactor-5-group-ldap-links
branch
from
September 14, 2026 18:04
ededc74 to
4ba0de2
Compare
rickbrouwer
deployed
to
Integrate Pull Request
September 14, 2026 18:05 — with
GitHub Actions
Active
GitHub Actions
Active
rickbrouwer
deployed
to
Integrate Pull Request
September 14, 2026 18:05 — with
GitHub Actions
Active
GitHub Actions
Active
rickbrouwer
marked this pull request as ready for review
September 14, 2026 18:29
amimas
reviewed
Sep 26, 2026
amimas
left a comment
amimas
left a comment
Collaborator
There was a problem hiding this comment.
A few places have GitLab's API attributes referenced. Is it possible to avoid it?
Collaborator
Author
I don't think we can avoid it. The config entries are keyed by an alias, so to match them against the existing links we have to compare the fields that identify a link (provider + cn or filter). It's the same pattern as title in the deploy keys processor and name in badges. |
rickbrouwer
deployed
to
Integrate Pull Request
September 26, 2026 17:11 — with
GitHub Actions
Active
GitHub Actions
Active
rickbrouwer
deployed
to
Integrate Pull Request
September 26, 2026 17:11 — with
GitHub Actions
Active
GitHub Actions
Active
amimas
reviewed
Sep 27, 2026
amimas
left a comment
amimas
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for clarifying the earlier inquiries. I missed something earlier but otherwise it looks good, I think.
amimas
approved these changes
Sep 27, 2026
rickbrouwer
force-pushed
the
refactor-5-group-ldap-links
branch
from
September 27, 2026 18:50
4500662 to
0dc16ab
Compare
rickbrouwer
deployed
to
Integrate Pull Request
September 27, 2026 18:50 — with
GitHub Actions
Active
GitHub Actions
Active
rickbrouwer
deployed
to
Integrate Pull Request
September 27, 2026 18:50 — with
GitHub Actions
Active
GitHub Actions
Active
rickbrouwer
enabled auto-merge (squash)
September 27, 2026 18:51
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
refactor-5-group-ldap-links
branch
from
September 28, 2026 04:42
0dc16ab to
81c0528
Compare
rickbrouwer
had a problem deploying
to
Integrate Pull Request
September 28, 2026 04:42 — with
GitHub Actions
Error
GitHub Actions
Error
rickbrouwer
had a problem deploying
to
Integrate Pull Request
September 28, 2026 04:42 — with
GitHub Actions
Error
GitHub Actions
Error
rickbrouwer
deployed
to
Integrate Pull Request
September 28, 2026 06:38 — with
GitHub Actions
Active
GitHub Actions
Active
rickbrouwer
deployed
to
Integrate Pull Request
September 28, 2026 06:38 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate group-ldap-links processor to python-gitlab.
Number 3 from #1359.