Repository navigation
Conversation
allin2
had a problem deploying
to
Integrate Pull Request
July 25, 2026 11:31 — with
GitHub Actions
Failure
allin2
requested a deployment
to
Integrate Pull Request
July 25, 2026 11:31 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
member_rolefor groups configured undergroup_members.groupsmember_role_idRoot cause
GroupMembersProcessor._process_groups()only considered group access andexpiration. It never resolved the configured custom role, and
python-gitlab's high-level
Group.share()method does not currently includemember_role_idin the request body.Changes
member-role lookup
member_role_idin the equality check so unchanged shares are notremoved and recreated
member_roleis removed from configurationValidation
.venv/bin/python -m pytest tests/unit— 242 passedUV_CACHE_DIR=/private/tmp/gitlabform-uv-cache uv run --no-sync qa lint— passedUV_CACHE_DIR=/private/tmp/gitlabform-uv-cache uv run --no-sync docs build— passedUV_CACHE_DIR=/private/tmp/gitlabform-uv-cache uv run --no-sync package build— passedUV_CACHE_DIR=/private/tmp/gitlabform-uv-cache uv run --no-sync package verify— passedtests/acceptance/ultimate/test_group_members.py— collection passed; runtimerequires a disposable GitLab Ultimate instance and was not available locally
Compatibility and risk
Existing configurations without
group_members.groups.*.member_rolekeep thesame behavior. No migration is required.
When the configured role differs, GitLabForm follows the processor's existing
update strategy of removing and recreating the group invitation. This may
create a brief access gap, but avoids repeated changes once the configured
state is applied.
Closes #1370