Repository navigation
fix(merge_requests_approval_rules): stop redundant edit calls on unchanged rules - #1350
Merged
Merged
Conversation
rickbrouwer
temporarily deployed
to
Integrate Pull Request
July 10, 2026 13:14 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
had a problem deploying
to
Integrate Pull Request
July 10, 2026 13:14 — with
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
force-pushed
the
approval-rules
branch
from
July 10, 2026 16:02
0c72672 to
103caf7
Compare
rickbrouwer
had a problem deploying
to
Integrate Pull Request
July 10, 2026 16:02 — with
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
temporarily deployed
to
Integrate Pull Request
July 10, 2026 16:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
force-pushed
the
approval-rules
branch
from
July 10, 2026 16:29
103caf7 to
055b1ad
Compare
rickbrouwer
temporarily deployed
to
Integrate Pull Request
July 10, 2026 16:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
had a problem deploying
to
Integrate Pull Request
July 10, 2026 16:29 — with
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
force-pushed
the
approval-rules
branch
from
July 10, 2026 17:07
055b1ad to
8bded37
Compare
rickbrouwer
temporarily deployed
to
Integrate Pull Request
July 10, 2026 17:07 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
had a problem deploying
to
Integrate Pull Request
July 10, 2026 17:07 — with
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
force-pushed
the
approval-rules
branch
from
July 10, 2026 17:29
8bded37 to
a30ae13
Compare
rickbrouwer
temporarily deployed
to
Integrate Pull Request
July 10, 2026 17:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
temporarily deployed
to
Integrate Pull Request
July 10, 2026 17:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
marked this pull request as ready for review
July 10, 2026 17:51
TimKnight01
approved these changes
Jul 14, 2026
…anged rules Signed-off-by: Rick Brouwer <[email protected]>
TimKnight01
force-pushed
the
approval-rules
branch
from
July 14, 2026 10:38
a30ae13 to
2d0cc4d
Compare
TimKnight01
temporarily deployed
to
Integrate Pull Request
July 14, 2026 10:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TimKnight01
temporarily deployed
to
Integrate Pull Request
July 14, 2026 10:39 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TimKnight01
approved these changes
Jul 14, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base _needs_update compared config keys (user_ids / group_ids / protected_branches as names) against the GitLab response shape (users / groups as object lists, protected_branches as dicts), so keys_only_in_configuration always fired and every run issued a PUT.
Override _needs_update to normalize both sides before comparing, and mirror edit_approval_rule's semantics that a missing list in config means "clear it".