Skip to content

fix: format group member expiry dates #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimKnight01 merged 5 commits into from
Jul 14, 2026
Merged

fix: format group member expiry dates #1349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50ea2c7
fix: format group member expiry dates
w3lld1 Jul 9, 2026
fe05ed9
Merge branch 'main' into fix/group-members-expires-at-date
w3lld1 Jul 10, 2026
cc78bc5
Merge branch 'main' into fix/group-members-expires-at-date
w3lld1 Jul 10, 2026
962cf7b
fix: share expiry date formatting across member processors
w3lld1 Jul 12, 2026
b503fe5
test: move expiry formatting coverage to util tests
w3lld1 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: move expiry formatting coverage to util tests
  • Loading branch information
@w3lld1
w3lld1 committed Jul 12, 2026
commit b503fe584dc9af8b0b12f96ca648a63232ad77ca
10 changes: 0 additions & 10 deletions tests/unit/processors/test_group_members_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,13 @@
from unittest.mock import MagicMock

from gitlabform.processors.group.group_members_processor import GroupMembersProcessor
from gitlabform.util import format_expires_at


class TestGroupMembersProcessor:
def setup_method(self):
self.processor = GroupMembersProcessor.__new__(GroupMembersProcessor)
self.processor.gl = MagicMock()

def test__format_expires_at_converts_date_to_gitlab_string(self):
assert format_expires_at(date(2026, 6, 18)) == "2026-06-18"

def test__format_expires_at_leaves_string_unchanged(self):
assert format_expires_at("2026-06-18") == "2026-06-18"

def test__format_expires_at_leaves_none_unchanged(self):
assert format_expires_at(None) is None

def test__process_groups_formats_date_expires_at_before_sharing(self):
group = MagicMock()
group.shared_with_groups = []
Expand Down
14 changes: 13 additions & 1 deletion tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import datetime

from gitlabform.util import to_str
from gitlabform.util import format_expires_at, to_str


def test_date_stringification():
Expand All @@ -18,3 +18,15 @@ def test_date_stringification():
}
output = to_str(example_project_config)
assert type(output) is str


def test_format_expires_at_converts_date_to_gitlab_string():
assert format_expires_at(datetime.date(2026, 6, 18)) == "2026-06-18"


def test_format_expires_at_leaves_string_unchanged():
assert format_expires_at("2026-06-18") == "2026-06-18"


def test_format_expires_at_leaves_none_unchanged():
assert format_expires_at(None) is None
Loading