fix: diff log should not require verbose by TimKnight01 · Pull Request #1343 · gitlabform/gitlabform

TimKnight01 · 2026-07-02T14:12:23Z

adds custom log levels to support two custom log types
resolves --diff-only-changed should show diffs without requiring --verbose #1315

codecov · 2026-07-09T09:40:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.89%. Comparing base (be7316d) to head (57ea27a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   78.24%   74.89%   -3.36%     
==========================================
  Files          83       83              
  Lines        4229     4234       +5     
==========================================
- Hits         3309     3171     -138     
- Misses        920     1063     +143

Flag	Coverage Δ
integration	`74.89% <100.00%> (+0.10%)`	⬆️
unittests	`?`

Files with missing lines	Coverage Δ
gitlabform/__init__.py	`67.13% <100.00%> (-14.72%)`	⬇️
gitlabform/constants.py	`100.00% <100.00%> (ø)`
gitlabform/processors/util/difference_logger.py	`84.00% <100.00%> (-7.67%)`	⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- adds custom log levels to support two custom log types Signed-off-by: Tim Knight <[email protected]>

Signed-off-by: Tim Knight <[email protected]>

TimKnight01 · 2026-07-13T08:50:01Z

@amimas updated following comments, thank you

amimas

From a quick glance over the file changes, it looks good to me @TimKnight01 . But, I haven't had a chance to try it out locally. Do we have any existing test cases or quick way to add some tests? Maybe we can look at those in the CI. Otherwise, would be nice to add some samples execution in the PR description from your local test run.

TimKnight01 · 2026-07-20T08:29:30Z

@amimas - you can see some of the results in the CI -> more logging, I can see if we can add one in, we'd need to I think check if it got written out with caplog, should be doable 🤔

amimas · 2026-08-02T20:02:51Z

Hey @TimKnight01 - Sorry, not sure what you were referring to as "in the CI -> more logging". Are you still looking into this? Just checking if we're good to merge this. The branch needs updating though.

TimKnight01 · 2026-08-03T09:14:10Z

@amimas - sorry I've started a new role at work so it's eaten a lot of my time, will try and get back to this this week if I can

amimas · 2026-08-06T02:44:39Z

No worries. I completely understand. Hope you're enjoying the new role.

rickbrouwer · 2026-09-09T11:01:22Z

I think docs/running.md also needs an update (there is a suggestion about --verbose --diff-only-changed)

Also I think we loses the styling. RichHandler has markup off by default (so, :sparkles: now prints literally ":sparkles:" and the red/green/yellow are gone).
Passing an extra={"markup": True} on those specific calls brings it back. So, please add this an test if I'm correct. I'd avoid markup=True on the handler itself btw, since diff output can contain brackets and would then raise a MarkupError.

Fix diff logging so bracket-heavy values are emitted as literal text instead of being parsed as Rich markup. Also added unit test for diff logger so to validate this fix as well as not requiring verbose mode for diff logging.

amimas · 2026-09-12T16:54:24Z

Thanks for those feedbacks @rickbrouwer . I just pushed an update. When you get a chance, could you please review?

rickbrouwer · 2026-09-12T17:20:04Z

@amimas
Is it okay if I check this out and make some adjustments? I'll make a separate commit so we can review the whole thing.

Signed-off-by: Rick Brouwer <[email protected]>

rickbrouwer · 2026-09-12T17:38:56Z

I’m just going to go ahead and do that (sorry 😉 ). If it’s not allowed or anything, I’m can drop the commit.

Personally, I think this commit does the trick, so I’m approving it now.
Feel free to take a look at it, and if you’re happy with it too, go ahead and merge it.

amimas · 2026-09-12T18:17:59Z

Ahh... ofcourse it's okay! Thanks for those adjustments and the review. Looks good to me. Going to merge this now.

TimKnight01 requested review from amimas and gdubicki as code owners July 2, 2026 14:12

TimKnight01 had a problem deploying to Integrate Pull Request July 2, 2026 14:12 — with GitHub Actions Error

TimKnight01 force-pushed the i-1315 branch from bf7d472 to 21710b0 Compare July 2, 2026 14:55

TimKnight01 had a problem deploying to Integrate Pull Request July 2, 2026 14:55 — with GitHub Actions Error

TimKnight01 had a problem deploying to Integrate Pull Request July 3, 2026 08:09 — with GitHub Actions Failure

TimKnight01 force-pushed the i-1315 branch from 21710b0 to 57ea27a Compare July 9, 2026 09:19

TimKnight01 temporarily deployed to Integrate Pull Request July 9, 2026 09:19 — with GitHub Actions Inactive

TimKnight01 force-pushed the i-1315 branch from 57ea27a to da49959 Compare July 10, 2026 08:39

TimKnight01 temporarily deployed to Integrate Pull Request July 10, 2026 08:39 — with GitHub Actions Inactive

amimas reviewed Jul 12, 2026

View reviewed changes

Comment thread gitlabform/constants.py

amimas reviewed Jul 12, 2026

View reviewed changes

Comment thread gitlabform/constants.py Outdated

fix: diff log should not require verbose

37bf28f

- adds custom log levels to support two custom log types Signed-off-by: Tim Knight <[email protected]>

TimKnight01 force-pushed the i-1315 branch from da49959 to 37bf28f Compare July 13, 2026 08:41

TimKnight01 had a problem deploying to Integrate Pull Request July 13, 2026 08:41 — with GitHub Actions Error

docs: improve logging levels docs

a814dc9

Signed-off-by: Tim Knight <[email protected]>

TimKnight01 had a problem deploying to Integrate Pull Request July 13, 2026 08:50 — with GitHub Actions Failure

TimKnight01 had a problem deploying to Integrate Pull Request July 14, 2026 09:12 — with GitHub Actions Failure

amimas approved these changes Jul 18, 2026

View reviewed changes

Merge branch 'main' into i-1315

4086355

amimas requested a review from rickbrouwer as a code owner September 9, 2026 00:28

amimas had a problem deploying to Integrate Pull Request September 9, 2026 00:28 — with GitHub Actions Error

rickbrouwer requested changes Sep 9, 2026

View reviewed changes

Comment thread docs/contrib/coding_guidelines.md Outdated

rickbrouwer requested changes Sep 9, 2026

View reviewed changes

Comment thread docs/contrib/coding_guidelines.md Outdated

amimas added 2 commits September 12, 2026 12:44

fix: diff log output under Rich and add unit test

a7515ee

Fix diff logging so bracket-heavy values are emitted as literal text instead of being parsed as Rich markup. Also added unit test for diff logger so to validate this fix as well as not requiring verbose mode for diff logging.

docs: update running instructions and development guide

cccbf8f

amimas had a problem deploying to Integrate Pull Request September 12, 2026 16:52 — with GitHub Actions Error

my update

834c099

Signed-off-by: Rick Brouwer <[email protected]>

rickbrouwer deployed to Integrate Pull Request September 12, 2026 17:37 — with GitHub Actions Active

rickbrouwer approved these changes Sep 12, 2026

View reviewed changes

amimas merged commit 08149ef into gitlabform:main Sep 12, 2026
23 checks passed

Conversation

TimKnight01 commented Jul 2, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

TimKnight01 commented Jul 13, 2026

Uh oh!

amimas left a comment

Choose a reason for hiding this comment

Uh oh!

TimKnight01 commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amimas commented Aug 2, 2026

Uh oh!

TimKnight01 commented Aug 3, 2026

Uh oh!

amimas commented Aug 6, 2026

Uh oh!

Uh oh!

Uh oh!

rickbrouwer commented Sep 9, 2026

Uh oh!

amimas commented Sep 12, 2026

Uh oh!

rickbrouwer commented Sep 12, 2026

Uh oh!

rickbrouwer commented Sep 12, 2026

Uh oh!

amimas commented Sep 12, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 9, 2026 •

edited

Loading

TimKnight01 commented Jul 20, 2026 •

edited

Loading