Repository navigation
fix: validate key in files config to avoid cryptic KeyError - #1317
Merged
Merged
Conversation
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
had a problem deploying
to
Integrate Pull Request
June 17, 2026 15:29 — with 
GitHub Actions
Failure
GitHub Actions
Failure
rickbrouwer
had a problem deploying
to
Integrate Pull Request
June 17, 2026 15:29 — with
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 78.04% 78.10% +0.06%
==========================================
Files 83 83
Lines 4163 4170 +7
==========================================
+ Hits 3249 3257 +8
+ Misses 914 913 -1
🚀 New features to boost your workflow:
|
amimas
reviewed
Jun 19, 2026
amimas
left a comment
amimas
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for looking into this @rickbrouwer . In general, looks good. Just have a question/suggestion on the approach.
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
temporarily deployed
to
Integrate Pull Request
June 19, 2026 08:06 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
temporarily deployed
to
Integrate Pull Request
June 19, 2026 08:06 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
temporarily deployed
to
Integrate Pull Request
June 22, 2026 05:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
temporarily deployed
to
Integrate Pull Request
June 22, 2026 05:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
amimas
approved these changes
Jun 22, 2026
TimKnight01
approved these changes
Jun 22, 2026
rickbrouwer
temporarily deployed
to
Integrate Pull Request
June 22, 2026 10:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
temporarily deployed
to
Integrate Pull Request
June 22, 2026 10:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
rickbrouwer
enabled auto-merge
June 22, 2026 10:58
rickbrouwer
disabled auto-merge
June 22, 2026 10:58
rickbrouwer
enabled auto-merge
June 22, 2026 10:59
TimKnight01
disabled auto-merge
June 23, 2026 08:42
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files processor accessed
configuration["files"][file]["branches"]directly, raisingKeyError: 'branches'when users omitted the key. The misleading error pointed users at their top-levelbranches:section instead of the missing sub-key under the file entry.Now exits with EXIT_INVALID_INPUT and a clear message listing the accepted values (
all,protected, or a list of branch names).Fixes #1312