Fix invalid <clear /> element in nuget.config example - #45908
Open
SurefireStudios wants to merge 1 commit into
Open
SurefireStudios wants to merge 1 commit into
SurefireStudios wants to merge 1 commit into
Conversation
The NuGet section wrote the element as `< clear />` with a space between the angle bracket and the tag name, in the XML example and twice in the surrounding prose. XML element names cannot begin with whitespace, so the example does not parse and NuGet rejects the resulting nuget.config. The correct spelling `<clear />` is already used in "Working with the NuGet registry".
Contributor
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Closes:
No existing issue — found by parsing every fenced
xmlblock incontent/."Remove access to public registries" writes the NuGet
clearelement as< clear />, with a space between the angle bracket and the tag name. XML element names cannot begin with whitespace, so:xmlexample does not parse as XML.nuget.config, which is the opposite of what the article is instructing readers to do.This is a typo rather than a convention: the correct spelling
<clear />is already used twice in Working with the NuGet registry, and< clear />appears nowhere else incontent/.What's being changed (if available, include any code snippets, screenshots, or gifs):
Removed the stray space in all three occurrences — once in the
xmlcode block, and twice in the prose that describes it (the prose is wrong in the same way, so fixing only the code block would leave the article inconsistent with itself).After the change the block parses, and the
packageSourcessection resolves as intended:Note: this touches the same article as #45907, but a different section and non-overlapping lines, so the two can merge in either order. Happy to combine them if you'd rather review one PR.
Check off the following: