[file_selector_android] Handle a null stream from openInputStream - #12716
Merged
Merged
Conversation
![gemini-code-assist[bot]](/web-api/iframe-proxy?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a crash that occurs when the Android content provider returns a null input stream for a selected file. It introduces null checks for the input stream in FileSelectorApiImpl.java and FileUtils.java, returning null or throwing an IOException respectively. Corresponding unit tests have been added to verify these behaviors, and the package version has been bumped to 0.5.2+11. There are no review comments, so I have no feedback to provide.
mboetger
requested review from
a team and
gmackall
and removed request for
a team
September 10, 2026 19:18
gmackall
approved these changes
Sep 10, 2026
mboetger
added
the
autosubmit
pull Bot
pushed a commit
to Mattlk13/flutter
that referenced
this pull request
Sep 11, 2026
…r#192630) flutter/packages@8a35b16...9caa77c 2026-09-11 [email protected] [pigeon] main actor async flutter api (flutter/packages#12729) 2026-09-10 [email protected] [image_picker] Handle a null stream from openInputStream (flutter/packages#12718) 2026-09-10 [email protected] [material_ui] 1.2.0 sync back clean up (flutter/packages#12829) 2026-09-10 [email protected] [material_ui] Support custom date input formatters via CalendarDelegate (flutter/packages#12608) 2026-09-10 [email protected] [in_app_purchase_storekit] Expose expiration date directly for subscriptions (flutter/packages#11551) 2026-09-10 [email protected] [file_selector_android] Handle a null stream from openInputStream (flutter/packages#12716) 2026-09-10 [email protected] [pigeon] Add FFI and JNI support to Swift and Kotlin (flutter/packages#11352) 2026-09-10 [email protected] [material_ui] Migrate M3 Card defaults to new gen_defaults (flutter/packages#12795) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null safety when ContentResolver cannot open a stream.
Copied from closed: #12683
Fixes: #191989
Pre-Review Checklist
[shared_preferences]///).