Conversation
`ContentResolver#openInputStream()` returns null when the provider cannot serve the item (a provider that crashed, a cloud-only photo it could not fetch). `FileUtils.getPathFromUri` passed that null into `copy()`, and the resulting NullPointerException on the delegate's executor thread killed the process (seen in the field on a Xiaomi device running Android 10). Return null instead, so the delegate reports `missing_valid_image_uri` as it does for the other unreadable cases.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Closing: I can't complete the CLA at this time. The analysis stays in the linked issue for anyone who wants to pick this up. |
11 tasks
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Null safety when ContentResolver cannot open a stream. Copied from closed: #12682 Fixes: flutter/flutter#191988 ## Pre-Review Checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentResolver#openInputStream()returns null when the provider cannot serve the picked item (a provider that crashed, a cloud-only photo it could not fetch).FileUtils.getPathFromUriopens the stream in a try-with-resources (where a null resource is legal) and hands it straight tocopy(); the resultingNullPointerExceptionon the delegate's executor thread is uncaught and kills the process. The null-URI sibling was guarded in #5009; the null-stream step right after it was not.This returns
nullfromgetPathFromUrifor a null stream, so the delegate reports the existingmissing_valid_image_urierror exactly as it does for the other unreadable cases, and adds a unit test in the shape of the existingSecurityExceptionone.Fixes flutter/flutter#191988
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2