Skip to content

Node.js SDK missing ignoreCache parameter in MapOptions #4535

Description

@Tetnofa

The ignoreCache parameter was added to the /map API endpoint in PR #2686 (v2.8.0), but it was never added to the Node.js SDK's MapOptions type.

Current MapOptions in @mendable/[email protected]:

export interface MapOptions {
  search?: string;
  sitemap?: "only" | "include" | "skip";
  includeSubdomains?: boolean;
  ignoreQueryParameters?: boolean;
  limit?: number;
  timeout?: number;
  integration?: string;
  origin?: string;
  location?: LocationConfig;
  threatProtection?: ThreatProtectionOptions;
  auditMetadata?: AuditMetadata;
}

ignoreCache is missing. It's documented in the REST API docs and appears to be available in the Python SDK, but the JS SDK type was never updated.

Expected: ignoreCache?: boolean should be added to MapOptions in src/v2/types.ts and passed through in src/v2/methods/map.ts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions