fix: Support ARM nodes in operator CronJobs - #6840
Open
Hanabi9248 wants to merge 1 commit into
Open
Hanabi9248 wants to merge 1 commit into
Hanabi9248 wants to merge 1 commit into
Conversation
Signed-off-by: Hanabi <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6840 +/- ##
=======================================
Coverage 47.11% 47.11%
=======================================
Files 419 419
Lines 51886 51886
Branches 7528 7528
=======================================
Hits 24448 24448
Misses 25688 25688
Partials 1750 1750
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The default CronJob runner image only publishes linux/amd64, so its init containers cannot start on ARM nodes. Use the official multi-architecture kubectl image, keeping v1.30.5 to match the client shipped in origin-cli:4.17. Update the operator defaults, deployment manifests and documentation together.
The existing image overrides and non-root security contexts are preserved. The runner only invokes kubectl; the bash command executes in the Feast deployment.
Which issue(s) this PR fixes:
Fixes #6836
Checks
git commit -s)Testing Strategy
Ran the services package tests on Linux with envtest 1.31.0, plus
go vet ./internal/controller/services. Kustomize 5.4.3 renders all 14 documents and the expected runner image. Verified the published image index includes arm64, and ran its amd64 kubectl binary as UID 1001. An ARM cluster and OpenShift end-to-end deployment were not tested.Misc
Release note: Operator CronJobs use a multi-architecture runner image so they can start on ARM nodes.