Skip to content

fix: Pull the MinIO test image from quay - #6838

Open
ntkathole wants to merge 2 commits into
feast-dev:masterfrom
ntkathole:fix_minio_image
Open

ntkathole wants to merge 2 commits into
feast-dev:masterfrom
ntkathole:fix_minio_image

Conversation

@ntkathole

Copy link
Copy Markdown
Member

What this PR does / why we need it:

The minio_registry tests use MinioContainer() from testcontainers, which defaults to minio/minio:RELEASE.2022-12-02T19-19-22Z on Docker Hub. That image is no longer pullable (access denied / repo removed).

Changed CI to pull quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z instead of Docker Hub.

@ntkathole ntkathole self-assigned this Sep 15, 2026
@ntkathole
ntkathole requested a review from a team as a code owner September 15, 2026 09:15
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.19%. Comparing base (787845a) to head (79f1e29).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6838   +/-   ##
=======================================
  Coverage   47.18%   47.19%           
=======================================
  Files         419      419           
  Lines       51964    51964           
  Branches     7548     7548           
=======================================
+ Hits        24521    24522    +1     
  Misses      25689    25689           
+ Partials     1754     1753    -1     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.50% <ø> (+<0.01%) ⬆️
see 1 file with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 787845a...79f1e29. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants