Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6829 +/- ##
==========================================
- Coverage 47.18% 47.16% -0.03%
==========================================
Files 419 419
Lines 51964 51997 +33
Branches 7548 7554 +6
==========================================
+ Hits 24521 24525 +4
- Misses 25689 25719 +30
+ Partials 1754 1753 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
force-pushed
the
iceberg_offline_write
branch
2 times, most recently
from
September 15, 2026 07:42
cd62ae9 to
bb7905e
Compare
Signed-off-by: ntkathole <[email protected]>
ntkathole
force-pushed
the
iceberg_offline_write
branch
from
September 16, 2026 14:46
bb7905e to
6829eb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a FeatureView's batch_source is an IcebergSource, calling fs.write_to_offline_store() or fs.push(to=PushMode.ONLINE_AND_OFFLINE) was not supported.
Added Offline write batch support for IcebergSource.