fix: Address PR #6093 review feedback

- Extract the duplicated updated_since cutoff normalization into the existing feast.utils.to_naive_utc helper (was copy-pasted in 4 places across caching_registry, registry, and snowflake — both list_all_feature_views paths). to_naive_utc already implements the exact tz-aware -> naive-UTC conversion, so behavior is unchanged. - REST list_all_feature_views: return HTTP 400 for a malformed updated_since value instead of letting datetime.fromisoformat raise and surface as a 500. - SqlRegistry._list_all_feature_views: add the explicit updated_since param so the override matches the CachingRegistry abstract signature (fixes a mypy override error introduced when merging master's **kwargs signature). - Snowflake updated_since unit tests: stub list_label_views in the fixture, since list_all_feature_views also aggregates label views. Signed-off-by: Nick Quinn <[email protected]>
feast-dev · nquinn408 · Jun 29, 2026 · Mar 10, 2026 · Mar 11, 2026 · Mar 11, 2026
commit 32973014bd518574ac7e94aea0f8bd83c82f2601
@@ -485,26 +485,36 @@ def _get_any_feature_view(self, name: str, project: str) -> BaseFeatureView:
         return fv
 
     def _list_all_feature_views(
-        self, project: str, tags: Optional[dict[str, str]], **kwargs
+        self,
+        project: str,
+        tags: Optional[dict[str, str]],
+        updated_since: Optional[datetime] = None,
+        **kwargs,
     ) -> List[BaseFeatureView]:
         return (
             cast(
                 list[BaseFeatureView],
-                self._list_feature_views(project=project, tags=tags, **kwargs),
+                self._list_feature_views(
+                    project=project, tags=tags, updated_since=updated_since, **kwargs
+                ),
             )
             + cast(
                 list[BaseFeatureView],
-                self._list_stream_feature_views(project=project, tags=tags, **kwargs),
+                self._list_stream_feature_views(
+                    project=project, tags=tags, updated_since=updated_since, **kwargs
+                ),
             )
             + cast(
                 list[BaseFeatureView],
                 self._list_on_demand_feature_views(
-                    project=project, tags=tags, **kwargs
+                    project=project, tags=tags, updated_since=updated_since, **kwargs
                 ),
             )
             + cast(
                 list[BaseFeatureView],
-                self._list_label_views(project=project, tags=tags, **kwargs),
+                self._list_label_views(
+                    project=project, tags=tags, updated_since=updated_since, **kwargs
+                ),
             )
         )
 

@@ -361,6 +361,9 @@ def mock_snowflake_registry():
         registry.registry_config = config
         registry.registry_path = "db.schema"
         registry.cache_mode = "sync"
+        # list_all_feature_views also aggregates label views; default to none so the
+        # updated_since tests only need to stub the feature-view list methods they exercise.
+        registry.list_label_views = MagicMock(return_value=[])
         yield registry