Skip to content

feat: Implemented Tiling Support for Time-Windowed Aggregations #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 3 commits into from
Nov 28, 2025
Merged

feat: Implemented Tiling Support for Time-Windowed Aggregations #5724

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0df22f3
feat: Implemented tiling support
ntkathole Nov 4, 2025
712d5f9
chore: Created Aggregation interface
ntkathole Nov 21, 2025
49c2792
Merge branch 'master' into aggregation_tiling
franciscojavierarceo Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Created Aggregation interface 
Signed-off-by: ntkathole <[email protected]>
  • Loading branch information
@ntkathole
ntkathole committed Nov 21, 2025
commit 712d5f92a419805c0e4501745b0443bf162ae910
2 changes: 2 additions & 0 deletions sdk/python/feast/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from feast.infra.offline_stores.redshift_source import RedshiftSource
from feast.infra.offline_stores.snowflake_source import SnowflakeSource

from .aggregation import Aggregation
from .batch_feature_view import BatchFeatureView
from .data_source import KafkaSource, KinesisSource, PushSource, RequestSource
from .dataframe import DataFrameEngine, FeastDataFrame
Expand All @@ -32,6 +33,7 @@
pass

__all__ = [
"Aggregation",
"BatchFeatureView",
"DataFrameEngine",
"Entity",
Expand Down
7 changes: 7 additions & 0 deletions sdk/python/feast/aggregation.py → sdk/python/feast/aggregation/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
"""
Aggregation module for Feast.
"""

from datetime import timedelta
from typing import Optional

Expand Down Expand Up @@ -91,3 +95,6 @@ def __eq__(self, other):
return False

return True


__all__ = ["Aggregation"]
6 changes: 3 additions & 3 deletions sdk/python/feast/infra/tiling/__init__.py → ...thon/feast/aggregation/tiling/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
4. Engine nodes: Convert back to engine format (e.g., from_pandas(), createDataFrame())
"""

from feast.infra.tiling.base import IRMetadata, get_ir_metadata_for_aggregation
from feast.infra.tiling.orchestrator import apply_sawtooth_window_tiling
from feast.infra.tiling.tile_subtraction import (
from feast.aggregation.tiling.base import IRMetadata, get_ir_metadata_for_aggregation
from feast.aggregation.tiling.orchestrator import apply_sawtooth_window_tiling
from feast.aggregation.tiling.tile_subtraction import (
convert_cumulative_to_windowed,
deduplicate_keep_latest,
)
Expand Down
0 sdk/python/feast/infra/tiling/base.py → sdk/python/feast/aggregation/tiling/base.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...python/feast/infra/tiling/orchestrator.py → .../feast/aggregation/tiling/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import pandas as pd

from feast.aggregation import Aggregation
from feast.infra.tiling.base import get_ir_metadata_for_aggregation
from feast.aggregation.tiling.base import get_ir_metadata_for_aggregation


def apply_sawtooth_window_tiling(
Expand Down
2 changes: 1 addition & 1 deletion ...on/feast/infra/tiling/tile_subtraction.py → ...st/aggregation/tiling/tile_subtraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import pandas as pd

from feast.aggregation import Aggregation
from feast.infra.tiling.base import get_ir_metadata_for_aggregation
from feast.aggregation.tiling.base import get_ir_metadata_for_aggregation


def convert_cumulative_to_windowed(
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/compute_engines/ray/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@ def _execute_tiled_aggregation(self, dataset: Dataset) -> DAGValue:
3. Convert to windowed aggregations
4. Convert pandas → Ray Dataset
"""
from feast.infra.tiling.orchestrator import apply_sawtooth_window_tiling
from feast.infra.tiling.tile_subtraction import (
from feast.aggregation.tiling.orchestrator import apply_sawtooth_window_tiling
from feast.aggregation.tiling.tile_subtraction import (
convert_cumulative_to_windowed,
deduplicate_keep_latest,
)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/compute_engines/spark/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ def _execute_tiled_aggregation(self, input_df: DataFrame) -> DAGValue:
)
aggs_by_window[agg.time_window].append(agg)

from feast.infra.tiling.orchestrator import apply_sawtooth_window_tiling
from feast.infra.tiling.tile_subtraction import (
from feast.aggregation.tiling.orchestrator import apply_sawtooth_window_tiling
from feast.aggregation.tiling.tile_subtraction import (
convert_cumulative_to_windowed,
deduplicate_keep_latest,
)
Expand Down
Loading