Skip to content

feat: Adding support to return additional features from vector retrieval for Milvus db #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 5 commits into from
Jan 28, 2025
Merged

feat: Adding support to return additional features from vector retrieval for Milvus db #4971

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7597c28
checking in progress but this Pr still is not ready yet
franciscojavierarceo Jan 25, 2025
e459606
feat: Adding new method to FeatureStore to allow more flexible retrie…
franciscojavierarceo Jan 27, 2025
94fef2c
Adding requested_features back into online_store
franciscojavierarceo Jan 27, 2025
b3c1a92
linter
franciscojavierarceo Jan 27, 2025
5c8760e
removed type adjustment
franciscojavierarceo Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter 
Signed-off-by: Francisco Javier Arceo <[email protected]>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Jan 27, 2025
commit b3c1a9213b8f455cfdaaebab60ffa665560815cd
6 changes: 5 additions & 1 deletion sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,11 @@ def retrieve_online_documents_v2(
entity_key_bytes = bytes.fromhex(
hit.get("entity", {}).get(composite_key_name, None)
)
entity_key_proto = deserialize_entity_key(entity_key_bytes) if entity_key_bytes else None
entity_key_proto = (
deserialize_entity_key(entity_key_bytes)
if entity_key_bytes
else None
)
for field in output_fields:
val = ValueProto()
# entity_key_proto = None
Expand Down