Skip to content

fix(res.send): add Content-Length header only if Transfer-Encoding is not present #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjohansebas merged 9 commits into from
Jun 16, 2026
Merged

fix(res.send): add Content-Length header only if Transfer-Encoding is not present #4893

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0391382
fix(respond): add Content-Length header only if Transfer-Encoding is …
YuryShkoda Apr 20, 2022
4443a21
fix(response): used get('Transfer-Encoding')
YuryShkoda Apr 21, 2022
713013f
test(res.send): covered Transfer-Encoding and Content-Length headers …
YuryShkoda Apr 21, 2022
619495f
chore(response): removed comment
YuryShkoda Apr 21, 2022
047a9e6
chore(res.redirect): revert changes to focus on res.send
YuryShkoda May 13, 2022
654c3b0
test(res.send): added tests for all transfer encodings
YuryShkoda May 13, 2022
e48c7bc
Merge branch 'master' of github.com:expressjs/express into res-header…
bjohansebas Jan 15, 2026
1f2ab4b
Merge branch 'master' of github.com:expressjs/express into res-header…
bjohansebas Jan 17, 2026
dddae18
docs: update History.md to include bug fix for HTTP header conflict i…
bjohansebas Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(response): removed comment
  • Loading branch information
@YuryShkoda
YuryShkoda committed Apr 21, 2022
commit 619495f095a5480e9e59207b953823f5b8d92a4a
1 change: 0 additions & 1 deletion lib/response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,6 @@ res.redirect = function redirect(url) {
// Respond
this.statusCode = status;

// FIXME
// Because Content-Length and Transfer-Encoding can't be present in the response headers together,
// Content-Length should be added only if there is no Transfer-Encoding header
if (!this.get('Transfer-Encoding')) {
Expand Down