Conversation
The ASCII scan checked 8 bytes per iteration with a branch each. Folding four loads into one mask check per 32 bytes is neutral on short strings and about 9% faster when appending long ASCII strings.
The 32-byte scan cost every short string an extra loop test before the original code, which showed up as +3% on TPC-H ingestion where almost all strings are shorter than 32 bytes. Gate it behind a single length test so short strings run exactly the previous code and only long inputs, where the scan runs at least twice, take the wide path. Locally: 40M 28-byte strings unchanged, 20M 208-byte strings -9%.
Collaborator
|
Thanks - good idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASCII scan checked 8 bytes per iteration with a branch each. Folding four loads into one mask check per 32 bytes is neutral on short string, bails out at first problem (so neutral on long one), but consume faster when appending long ASCII-only strings.