This repository was archived by the owner on Sep 9, 2026. It is now read-only.
fix: fix dynamic class creation with doubly nested schemas - #1747
Merged
Merged
Conversation
Signed-off-by: Alaeddine Abdessalem <[email protected]>
Signed-off-by: Alaeddine Abdessalem <[email protected]>
Signed-off-by: Alaeddine Abdessalem <[email protected]>
alaeddine-13
force-pushed
the
fix-create-from-schema
branch
from
August 10, 2023 11:49
a0a81a3 to
bc3e1d6
Compare
|
📝 Docs are deployed on https://ft-fix-create-from-schema--jina-docs.netlify.app 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
+ Coverage 83.60% 85.00% +1.39%
==========================================
Files 134 134
Lines 8838 8842 +4
==========================================
+ Hits 7389 7516 +127
+ Misses 1449 1326 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
samsja
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the following case results in a KeyError:
the reason is,
create_base_doc_from_schemawill keep referring todefinitionsfield of the traversed schema when creating its corresponding model. However, thedefinitionsfield only exists for the root schema