Repository navigation
Allow an optional origin in world frame constructors - #1534
Open
ArianMoeini wants to merge 2 commits into
Open
ArianMoeini wants to merge 2 commits into
ArianMoeini wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1141.
Allow
Frame.worldXY(),Frame.worldYZ(), andFrame.worldZX()to take an optional origin as a coordinate sequence orPoint. Calls without an argument still use[0, 0, 0], and each frame keeps its existing axis directions.The constructor docstrings show the new usage, and a parameterized test covers all three frames with both accepted point forms. I also added the changelog entry and contributor credit required by
CONTRIBUTING.md.What type of change is this?
Checklist
CHANGELOG.mdunderUnreleased.ruff check .reports 12 existing issues outside the changed files;ruff checkandruff format --checkpass for the changed Python files.The frame module doctests also pass (19 passed).