Repository navigation
Conversation
ForAllWindows copies the window list every frame so callbacks run outside the manager lock. Make the snapshot vector thread_local and use assign() to reuse its capacity across frames, avoiding a heap allocation on every render tick. Signed-off-by: wall3rsyt <[email protected]>
github-actions
Bot
added
the
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ForAllWindowssnapshot vectorthread_localand fill it withassign()instead of copy-constructing a new vector every frame.Why / impact
ForAllWindowscopies the window list each frame so callbacks run outside the manager lock (avoiding deadlocks with window creation/destruction). The copy currently heap-allocates a fresh vector every call. Making the vectorthread_locallets successive frames reuse its capacity, removing a per-frame allocation from the render hot path.Trade-offs
None. The snapshot is cleared and reassigned each call;
thread_localstorage is destroyed at thread exit.Testing
Compiled and linked
nui-corein a local Debug x64 client build. Not runtime-tested in-game.