Skip to content

Avoid KeyError on unsuccessful _clear_uncommitted_blocks #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahurst-openai wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Avoid KeyError on unsuccessful _clear_uncommitted_blocks #237

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
294ac0b
Better handle the case where `_clear_uncommitted_blocks` returns a no…
ahurst-openai Apr 30, 2024
1aec035
Fix type.
ahurst-openai May 1, 2024
197a0fd
Replace deprecated .utcnow() to make CI happy.
ahurst-openai May 1, 2024
6aefddf
Huh, pyright rejected its own suggestion, which is correct:
ahurst-openai May 1, 2024
4dab4c9
Run black.
ahurst-openai May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type.
  • Loading branch information
@ahurst-openai
ahurst-openai committed May 1, 2024
commit 1aec035441607d3ee5c258ae474fb203f1cb74ac
2 changes: 1 addition & 1 deletion blobfile/_azure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@ def _block_index_to_block_id(index: int, upload_id: int) -> str:


def _clear_uncommitted_blocks(
conf: Config, url: str, metadata: Dict[str, str]
conf: Config, url: str, metadata: urllib3.HTTPHeaderDict
) -> Optional["urllib3.BaseHTTPResponse"]:
# to avoid leaking uncommitted blocks, we can do a Put Block List with
# all the existing blocks for a file
Expand Down