Repository navigation
Avoid KeyError on unsuccessful _clear_uncommitted_blocks - #237
Open
ahurst-openai wants to merge 5 commits into
Open
ahurst-openai wants to merge 5 commits into
ahurst-openai wants to merge 5 commits into
Conversation
…n-successful HttpResponse. This will fail with a `KeyError` because the `etag` header is missing.
Author
|
I preserved the apparent intention to silently tolerate an unsuccessful An alternative implementation would be to intercept the 4xx HTTP status code [from the last request] inside |
ahurst-openai
changed the title
datetime.UTC Alias for the UTC timezone singleton datetime.timezone.utc. Added in version 3.11. Fixed used datetime.timezone.utc directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handle the case where
_clear_uncommitted_blocksreturns with an unsuccessful HttpResponse.Currently this will raise a
KeyErrorbecause theetagheader is missing.