Repository navigation
DefaultAddressParserProvider: improve Javadoc, enable external subclasses - #4371
Open
msgilligan wants to merge 4 commits into
Open
msgilligan wants to merge 4 commits into
msgilligan wants to merge 4 commits into
Conversation
The list of normalized networks for Base58 should be: TESTNET,SIGNET,REGTEST not: TESTNET,REGTEST,REGTEST
Explain the difference between the two constructors and provide more detail on what the two static constant lists of networks are for.
Make the class itself `public` and the two-arg constructor `protected`. This will enable users to create subclasses that could for example, add network types such as Liquid.
A parser returned from forNetwork() with an invalid network would throw when any address is parsed, but this change will fail sooner (i.e. before the parser is created.)
msgilligan
force-pushed
the
msgilligan/address-parsing-javadoc-p2poolv2
branch
from
September 16, 2026 23:21
acefce3 to
5e590fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 commits:
Address.DefaultAddressParserProviderDefaultAddressParserProviderDefaultAddressParserProviderearlier.